What makes a hero, anyway?

This whole Trump vs McCain flap has me mystified.  Now, I have to admit that I don't know Sen. McCain's complete and total military service record.  But our post-Vietnam culture seems to "honor" people who wear the uniform, seemingly simply because they... wear the uniform.  We don't ask whether or not they do anything particularly noble while they have it on.  Lots of people who wore the uniform did awful things while wearing it; do we "honor their service", too?  Which people, you ask?  Oh, how about:

     > Gen. Sherman and his men, who burned their way through the Confederate south to the sea
     > Gen. Custer and his men, who massacred American Indians
     > The National Guard troops who "kept the peace" in Little Rock by keeping the races apart
     > The U.S. soldiers responsible for the My Lai massacre in Vietnam (John McCain's contemporaries)
     > The initial massacre of American Indians at Wounded Knee followed some 75 years later by another siege and firefight there
     > The Torture and abuse at Abu Grahib prison in Iraq
     > The officers who winked at sexual assault reported by female military beneath them

Shouldn't our honor be reserved for those who are in fact honorable?  If someone is serving their country in the military, they are doing so for a salary and benefits, including a military pension.  If they are sent into combat, they get extra combat pay.  As Jesus himself said in Luke 17:6-10, "Does he thank that servant because he did the things that were commanded him? I think not. So likewise you, when you have done all those things which you are commanded, say, ‘We are unprofitable servants. We have done what was our duty to do.’”

Putting on the uniform doesn't make one a hero.  Doing your duty doesn't make one a hero.  Surviving imprisonment doesn't make you a hero.  It makes you a survivor.  What makes one a hero?  Doing something heroic.

John McCain got medals, some for distinguished or meritorious service.  So did a lot of POWs.  The military uses words like valor or gallantry or heroism interchangeably with meritorious (incl. exceptionally meritorious) or distinguished service in the definition of their medals.  You really have to understand the specific acts for which the medal was awarded to determine if there was actual heroism involved, or if the veteran was merely highly effective in what they did (mostly killing the enemy).  At this point, I have no idea, nor likely does Donald Trump, whether or not McCain demonstrated true heroism or not.  What I do know about him is that he is quick-tempered and pugilistic in the area of foreign policy.  He is a leading "hawk" in Congress, and I hope he is defeated in his attempt at re-election.  I don't trust him with his finger on the red button, or anywhere near it.  Nor do I think (like the author of the linked article immediately above) that his time in a POW camp accords him anything more than sympathy for his injuries, simple acknowledgment for doing his duty while in the service, and respect for withstanding a hostile prison environment.  But hero?  I haven't seen that evidence yet.  For all I know, Trump has it right.